jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1810974270
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -298,8 +301,15 @@ private List<String> deleteBatch(String bucket,
Collection<String> keysToDelete)
@Override
public Iterable<FileInfo> listPrefix(String prefix) {
S3URI s3uri = new S3URI(prefix,
s3FileIOProperties.bucketToAccessPointMapping());
+ String suffix = "";
Review Comment:
can we embed this logic in S3URI? Something like
```java
if
(3FileIOProperties.isTreatS3DirectoryBucketListPrefixAsDirectoryEnabled()) {
S3URI s3uri = s3uri.toDirectoryPath()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
