jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1810952792
##########
aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java:
##########
@@ -127,6 +129,21 @@ public static void cleanS3Bucket(S3Client s3, String
bucketName, String prefix)
}
}
+ /**
+ * Method used to clean up a S3 directory bucket which doesn't care about
versions
+ *
+ * @param s3FileIO an instance of s3FileIO to be used to list/delete objects
+ * @param bucketName name of the bucket
+ * @param prefix the path prefix we want to remove
+ */
+ public static void cleanS3DirectoryBucket(S3FileIO s3FileIO, String prefix,
String bucketName) {
Review Comment:
I general I think we should support directory bucket listing, but we should
not use that to clean test bucket. The reason `cleanS3GeneralPurposeBucket` did
not use S3FileIO is that this is the test suite for S3FileIO, if the logic is
somehow wrong then the listing and cleanup would break. We want to directly
call the raw client to perform the delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
