stubz151 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1811021800
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -443,6 +453,16 @@ public boolean recoverFile(String path) {
return recoverVersion.map(version -> recoverObject(version,
location.bucket())).orElse(false);
}
+ /**
+ * Check for a bucket name matching -does not look at endpoint.
+ *
+ * @param bucket bucket to probe.
+ * @return true if the suffix is present
+ */
+ public static boolean checkIfS3Express(final String bucket) {
+ return bucket.endsWith(S3EXPRESS_STORE_SUFFIX);
Review Comment:
Think the only thing I can think of is you have to create an S3Uri object
everytime you want to check if it is a directory bucket, Is that what we want?
Think it is more accessible as a static method but open to suggestions,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
