jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1813050472
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java:
##########
@@ -115,4 +118,25 @@ public String scheme() {
public String toString() {
return location;
}
+
+ public S3URI toDirectoryPath() {
+ if (key.endsWith(PATH_DELIM)) {
+ return new S3URI(location);
+ }
+ return new S3URI(location + PATH_DELIM);
+ }
+
+ public boolean isS3DirectoryBucket() {
Review Comment:
I guess we should use the term `useS3DirectoryBucket()` which seems to fit
better, since `S3URI` itself is not a directory bucket, but the URI can use a
directory bucket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
