jackye1995 commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1803391775
##########
aws/src/integration/java/org/apache/iceberg/aws/AwsIntegTestUtil.java:
##########
@@ -106,7 +109,7 @@ public static String testMultiRegionAccessPointAlias() {
return System.getenv("AWS_TEST_MULTI_REGION_ACCESS_POINT_ALIAS");
}
- public static void cleanS3Bucket(S3Client s3, String bucketName, String
prefix) {
+ public static void cleanS3GeneralBucket(S3Client s3, String bucketName,
String prefix) {
Review Comment:
Looks like this is called "general purpose bucket":
https://aws.amazon.com/s3/faqs/
> Q: What is an S3 general purpose bucket?
> A bucket is a container for objects stored in Amazon S3, and you can store
any number of objects in a bucket. General purpose buckets are the original S3
bucket type, and a single general purpose bucket can contain objects stored
across all storage classes except S3 Express One Zone. They are recommended for
most use cases and access patterns.
Could you update the naming to be consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
