advancedxy commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1697812946
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1446,6 +1480,12 @@ public TableMetadata build() {
"Cannot set metadata location with changes to table metadata: %s
changes",
changes.size());
+ if (hasRemovedSpecs) {
+ Preconditions.checkArgument(
+ !hasPartitionSpecUpdates(),
+ "Cannot remove partition specs with other partition spec update");
Review Comment:
Ah yes. The reason I added these checks are purely for safety reasons: to
isolated the `RemoveUnusedSpecs` operation and don't interfere with other
updates.
I can relax this constraint if that's not an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
