rdblue commented on code in PR #10755: URL: https://github.com/apache/iceberg/pull/10755#discussion_r1697281086
########## core/src/main/java/org/apache/iceberg/TableMetadata.java: ########## @@ -1446,6 +1480,12 @@ public TableMetadata build() { "Cannot set metadata location with changes to table metadata: %s changes", changes.size()); + if (hasRemovedSpecs) { + Preconditions.checkArgument( + !hasPartitionSpecUpdates(), + "Cannot remove partition specs with other partition spec update"); Review Comment: This should not be a requirement. It is reasonable to add a new spec, set the default partition spec, and then remove the old spec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org