advancedxy commented on code in PR #10755: URL: https://github.com/apache/iceberg/pull/10755#discussion_r1697297712
########## api/src/main/java/org/apache/iceberg/RemoveUnusedSpecs.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; + +/** + * API for removing partition specs from the metadata which are not the default spec and no longer + * refer to any datafiles in the table. + * + * <p>{@link #apply()} returns the specs that will remain if committed on the current metadata + */ +public interface RemoveUnusedSpecs extends PendingUpdate<List<PartitionSpec>> {} Review Comment: > ```java table.maintenance() .removeUnusedSpecs() .removeUnusedSchemas() .commit() ``` This looks promising. But what if we need to further configure the maintenance operations, such as ```java table.maintenance().removeUnusedSpecs().retainLast(num).commit(); // or something table.maintenance().removeUnusedSchemas().setMinSchemasToKeep(num).commit(); ``` Different maintenance operations may have different configure options. It would be better to use a dedicated operation for each purpose? Of course, It would be great that these maintenance APIs are grouped together. > Have you considered that? Since expiration already reads manifests that could be a good place to do this. This is attempting and to be honest I haven't thought about it. Update: just did a quick look at the RemoveSnapshots' implementation, it might add too much complexity to put remove unused spec logic in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
