advancedxy commented on code in PR #10755: URL: https://github.com/apache/iceberg/pull/10755#discussion_r1697811542
########## api/src/main/java/org/apache/iceberg/RemoveUnusedSpecs.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; + +/** + * API for removing partition specs from the metadata which are not the default spec and no longer + * refer to any datafiles in the table. + * + * <p>{@link #apply()} returns the specs that will remain if committed on the current metadata + */ +public interface RemoveUnusedSpecs extends PendingUpdate<List<PartitionSpec>> {} Review Comment: > I think a decent example to look at would be the ManageSnapshots API which handles cherry picking/rollback and branching/tagging operations. Yes, I am thinking about something similar to that. > If i think about when it makes sense for this cleanup to happen ExpireSnapshots does make sense. I also don't know what we'd call a separate "maintenance" API since there's quite a few maintenance operations in Iceberg. I agree it's attempting. But I would prefer to use a maintenance API, for the following reasons: 1. Currently `ExpireSnapshots` extends `PendingUpdate<List<Snapshot>>`, if we are going to remove unused spec(and maybe unused schemas as well), we have to change the interface signature, which is breaking change. 2. ExpireSnapshots doesn't read manifest list yet, it only leverage `SnapshotRef` and `Snapshot` to calculate expired snapshots. It's adding complexity and breaks the [do one thing and do it well](https://en.wikipedia.org/wiki/Unix_philosophy) philosophy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
