advancedxy commented on code in PR #10755: URL: https://github.com/apache/iceberg/pull/10755#discussion_r1700397090
########## core/src/main/java/org/apache/iceberg/MetadataUpdate.java: ########## @@ -165,6 +165,25 @@ public void applyTo(TableMetadata.Builder metadataBuilder) { } } + class RemoveUnusedSpecs implements MetadataUpdate { + private final Set<Integer> specIds; + + public RemoveUnusedSpecs(Set<Integer> specIds) { + this.specIds = specIds; + } + + public Set<Integer> specIds() { + return specIds; + } + + @Override + public void applyTo(TableMetadata.Builder metadataBuilder) { + // metadataBuilder.removeUnusedSpecsById(specIds); + throw new UnsupportedOperationException( + "RemoveUnusedSpecs is not supported for REST catalog yet"); Review Comment: Thanks, let me remove this apply method for now. The default implementation already throws an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org