rdblue commented on code in PR #10523:
URL: https://github.com/apache/iceberg/pull/10523#discussion_r1685019500
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -410,6 +409,7 @@ public void commit() {
// to ensure that if a concurrent operation assigns the
UUID, this operation will
// not fail.
taskOps.commit(base, updated.withUUID());
+ committedSnapshot.set(newSnapshot);
Review Comment:
The big problem is that this is set after `commit` is called. Can you
refactor to avoid that? You'll just have to make sure that the commit succeeded
in all cases before using the snapshot since you no longer have the guarantee
that the snapshot was found in the table metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
