rdblue commented on code in PR #10523:
URL: https://github.com/apache/iceberg/pull/10523#discussion_r1678536233
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -192,6 +192,11 @@ protected void cleanUncommitted(Set<ManifestFile>
committed) {
}
}
+ @Override
+ protected boolean cleanupAfterCommit() {
Review Comment:
If the commit fails, when is `appendManifests` cleaned up? I thought that
`writeNewManifests` would replace the append manifests, but if no commit
succeeds then what cleans up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
