amogh-jahagirdar commented on code in PR #10523:
URL: https://github.com/apache/iceberg/pull/10523#discussion_r1693715757
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -422,26 +422,23 @@ public void commit() {
throw e;
}
+ // at this point, the commit must have succeeded so the stagedSnapshot
is committed
+ Snapshot committedSnapshot = stagedSnapshot.get();
try {
- LOG.info("Committed snapshot {} ({})", newSnapshotId.get(),
getClass().getSimpleName());
-
- // at this point, the commit must have succeeded. after a refresh, the
snapshot is loaded by
- // id in case another commit was added between this commit and the
refresh.
- Snapshot saved = ops.refresh().snapshot(newSnapshotId.get());
- if (saved != null) {
- cleanUncommitted(Sets.newHashSet(saved.allManifests(ops.io())));
- // also clean up unused manifest lists created by multiple attempts
- for (String manifestList : manifestLists) {
- if (!saved.manifestListLocation().equals(manifestList)) {
- deleteFile(manifestList);
- }
+ LOG.info(
+ "Committed snapshot {} ({})",
+ committedSnapshot.snapshotId(),
+ getClass().getSimpleName());
+
+ if (cleanupAfterCommit()) {
+
cleanUncommitted(Sets.newHashSet(committedSnapshot.allManifests(ops.io())));
+ }
+ // also clean up unused manifest lists created by multiple attempts
+ for (String manifestList : manifestLists) {
+ if (!committedSnapshot.manifestListLocation().equals(manifestList)) {
+ deleteFile(manifestList);
}
- } else {
- // saved may not be present if the latest metadata couldn't be
loaded due to eventual
- // consistency problems in refresh. in that case, don't clean up.
- LOG.warn("Failed to load committed snapshot, skipping manifest
clean-up");
}
Review Comment:
It's nice with this refactoring we're able to remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
