amogh-jahagirdar commented on code in PR #10523:
URL: https://github.com/apache/iceberg/pull/10523#discussion_r1676297839
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -198,6 +198,14 @@ protected void cleanUncommitted(Set<ManifestFile>
committed) {
}
}
+ @Override
+ protected boolean cleanUncommittedAfterCommit() {
+ // appendManifests are not rewritten, never need cleanup
+ // rewrittenAppendManifests are rewritten in appendManifest, never need
cleanup
+ // newManifests are cleaned up in writeNewManifests
Review Comment:
Nit: I'd make this a method level comment instead of inlining all this.
```
/**
Cleanup after committing is disabled for FastAppend for the following
reasons:
1.) Appended manifests are never rewritten
2.) Manifests which are written out as part of appendFile are already
cleaned up between commit attempts
in writeNewManifests
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
