grantatspothero commented on code in PR #10523:
URL: https://github.com/apache/iceberg/pull/10523#discussion_r1684850551
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -410,6 +409,7 @@ public void commit() {
// to ensure that if a concurrent operation assigns the
UUID, this operation will
// not fail.
taskOps.commit(base, updated.withUUID());
+ committedSnapshot.set(newSnapshot);
Review Comment:
Without doing this, the downside is we have to re-read from objectstorage
the snapshot we just wrote on every commit, which also is not good.
Writing to an atomic reference is lightweight. Feels like a reasonable
tradeoff. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
