grantatspothero commented on code in PR #10523:
URL: https://github.com/apache/iceberg/pull/10523#discussion_r1684858115
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -192,6 +192,11 @@ protected void cleanUncommitted(Set<ManifestFile>
committed) {
}
}
+ @Override
+ protected boolean cleanupAfterCommit() {
Review Comment:
`appendManifests` shouldn't be cleaned up because they are not written by
`FastAppend`.
see existing comment in `cleanUncommitted` method
```
// clean up only rewrittenAppendManifests as they are always owned by the
table
// don't clean up appendManifests as they are added to the manifest list and
are not compacted
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
