syun64 commented on PR #473: URL: https://github.com/apache/iceberg-python/pull/473#issuecomment-1979164521
> This looks great, one minor suggestion: > > Could you add the `legacy-current-snapshot-id` key to the write options table as well: https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/configuration.md#write-options I have this configuration documented under "Backward Compatibility" in the documentation now. I feel a bit awkward adding it to the write-options because the current list of write-options map to pyarrow parquet properties. Are you suggesting that we just add the property to the write-options in the documentation as well? Like: ## Write options | Key | Options | Default | Description | | --------------------------------- | --------------------------------- | ------- | ------------------------------------------------------------------------------------------- | | `write.parquet.compression-codec` | `{uncompressed,zstd,gzip,snappy}` | zstd | Sets the Parquet compression coddec. | | `write.parquet.compression-level` | Integer | null | Parquet compression level for the codec. If not set, it is up to PyIceberg | | `write.parquet.page-size-bytes` | Size in bytes | 1MB | Set a target threshold for the approximate encoded size of data pages within a column chunk | | `write.parquet.page-row-limit` | Number of rows | 20000 | Set a target threshold for the approximate encoded size of data pages within a column chunk | | `write.parquet.dict-size-bytes` | Size in bytes | 2MB | Set the dictionary page size limit per row group | | `write.parquet.row-group-limit` | Number of rows | 122880 | The Parquet row group limit | | `legacy-current-snapshot-id` | `{True,False}` | False | Set `current-snapshot-id` in serialized TableMetadata as `-1` instead of `None` | Are we looking to move the documentation to Write options or have it in both places? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
