HonahX commented on code in PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#discussion_r1510415931
##########
pyiceberg/serializers.py:
##########
@@ -127,6 +127,6 @@ def table_metadata(metadata: TableMetadata, output_file:
OutputFile, overwrite:
overwrite (bool): Where to overwrite the file if it already
exists. Defaults to `False`.
"""
with output_file.create(overwrite=overwrite) as output_stream:
- json_bytes = metadata.model_dump_json().encode(UTF8)
+ json_bytes =
metadata.model_dump_json(exclude_none=False).encode(UTF8)
Review Comment:
Maybe not a big deal: Shall we set `exclude_none=False` only in the legacy
mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
