Fokko commented on PR #473: URL: https://github.com/apache/iceberg-python/pull/473#issuecomment-1966093070
Thanks @syun64 for raising this. I agree with @HonahX that setting it to `-1` is not a good idea, for mainly two reasons: - There are two options for representing saying that the `current-snapshot-id` should be ignored, both `-1` and `None`. - Where `-1` does not point to a valid snapshot. However Java is the reference implementation, we should not blindly follow everything that they did there. There are some things in there that we can improve on since we don't carry the full history that Java does. Can you elaborate on why you need this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
