syun64 commented on PR #473: URL: https://github.com/apache/iceberg-python/pull/473#issuecomment-1971467546
> I prefer to not exclude certain groups (Java <1.3.0 in this case, I'm not sure on which versions all the proprietary implementations). I think a flag is an elegant way of enabling this. I fully agree with you on the documentation part of it 👍 > > > Would the compatibility flag be included as a environment variable? > > The flag would be a configuration option on the catalog. This way you can set it through the `~/.pyiceberg.yaml` and through an environment variable if you like. That makes sense @Fokko . What are your thoughts on [my findings](https://github.com/apache/iceberg-python/pull/473#issuecomment-1967538763) about the pydantic base model? I don't think there's an easy way to use a custom serializer only on the output, because we are using exclude_none=True on the model. So it will ignore the current_snapshot_id attribute if we stored it as None internally. So do we want to: 1. Store `current_snapshot_id` as '-1' internally if we have this flag set to True? Or 2. model_dump a dictionary, and add current_snapshot_id as `-1` if not present, then json.dumps(model_dump) on output serialization if the flag is set to True? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
