HonahX commented on PR #473:
URL: https://github.com/apache/iceberg-python/pull/473#issuecomment-1979926180

   Hi @Fokko @syun64 
   > I feel a bit awkward adding it to the write-options because the current 
list of write-options map to pyarrow parquet properties.
   
   I have a similar feeling, mainly because write-options table is for table 
properties while the `legacy-current-snapshot-id` is a global config in 
`~/.pyiceberg.yaml`
   ```yaml
   catalog:
     default:
       type: glue
    
   legacy-current-snapshot-id: True
   ```
   
   > Shall we merge this in if the place in the documentation..
   
   Let's get this in first. Thanks for the great effort on it. Thanks everyone 
for reviewing!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to