HonahX commented on PR #473: URL: https://github.com/apache/iceberg-python/pull/473#issuecomment-1965634235
Thanks for the great catch @syun64 ! My understanding is that we need to write `current_snapshot_id` to `-1` when serializing the new metadata object to JSON. Would it be better to directly update the serializer to support this backwards compatibility? [ToOutputFile.table_metadata](https://github.com/apache/iceberg-python/blob/main/pyiceberg/serializers.py#L118-L132) Internally, either `-1` or `None` can represent "no current snapshot id". But I think `None` is better as it aligns more with the [spec](https://iceberg.apache.org/spec/#table-metadata-fields) which states that `current_snapshot_id` is optional and make things more intuitive. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
