nastra commented on code in PR #9416:
URL: https://github.com/apache/iceberg/pull/9416#discussion_r1452234786
##########
core/src/test/java/org/apache/iceberg/TestLocalFilterFiles.java:
##########
@@ -18,20 +18,17 @@
*/
package org.apache.iceberg;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import java.util.Arrays;
+import java.util.List;
+import org.junit.jupiter.api.extension.ExtendWith;
-@RunWith(Parameterized.class)
+@ExtendWith(ParameterizedTestExtension.class)
public class TestLocalFilterFiles
extends FilterFilesTestBase<TableScan, FileScanTask, CombinedScanTask> {
- @Parameterized.Parameters(name = "formatVersion = {0}")
- public static Object[] parameters() {
- return new Object[] {1, 2};
- }
-
- public TestLocalFilterFiles(int formatVersion) {
- super(formatVersion);
+ @Parameters(name = "formatVersion = {0}")
+ public static List<Object> parameters() {
+ return Arrays.asList(new Object[] {1}, new Object[] {2});
Review Comment:
```suggestion
return Arrays.asList(1, 2);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
