chinmay-bhat commented on code in PR #9416:
URL: https://github.com/apache/iceberg/pull/9416#discussion_r1452222035
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -173,7 +173,7 @@ public class TestBase {
public TestTables.TestTable table = null;
@Parameters(name = "formatVersion = {0}")
- protected static List<Object[]> parameters() {
+ protected static List<Object> parameters() {
Review Comment:
That would work if the inputs were only Integers. But that's not the case
for all child classes.
For ex: `TestSparkDistributedDataScanDeletes` inherits from
`DeleteFileIndexTestBase` has additional parameters, that need to be wrapped
into `Object[]`.
```
@Parameters(name = "formatVersion = {0}, dataMode = {1}, deleteMode = {2}")
public static List<Object> parameters() {
return Arrays.asList(
new Object[] {2, LOCAL, LOCAL},
new Object[] {2, LOCAL, DISTRIBUTED},
new Object[] {2, DISTRIBUTED, LOCAL},
new Object[] {2, LOCAL, DISTRIBUTED});
}
```
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -173,7 +173,7 @@ public class TestBase {
public TestTables.TestTable table = null;
@Parameters(name = "formatVersion = {0}")
- protected static List<Object[]> parameters() {
+ protected static List<Object> parameters() {
Review Comment:
That would work if the inputs were only `Integers`. But that's not the case
for all child classes.
For ex: `TestSparkDistributedDataScanDeletes` inherits from
`DeleteFileIndexTestBase` has additional parameters, that need to be wrapped
into `Object[]`.
```
@Parameters(name = "formatVersion = {0}, dataMode = {1}, deleteMode = {2}")
public static List<Object> parameters() {
return Arrays.asList(
new Object[] {2, LOCAL, LOCAL},
new Object[] {2, LOCAL, DISTRIBUTED},
new Object[] {2, DISTRIBUTED, LOCAL},
new Object[] {2, LOCAL, DISTRIBUTED});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
