chinmay-bhat commented on code in PR #9416:
URL: https://github.com/apache/iceberg/pull/9416#discussion_r1451573049
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/SparkDistributedDataScanTestBase.java:
##########
@@ -21,46 +21,41 @@
import static org.apache.iceberg.PlanningMode.DISTRIBUTED;
import static org.apache.iceberg.PlanningMode.LOCAL;
+import java.util.Arrays;
+import java.util.List;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.spark.SparkReadConf;
import org.apache.spark.sql.SparkSession;
import org.apache.spark.sql.internal.SQLConf;
-import org.junit.Before;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-import org.junit.runners.Parameterized.Parameters;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.extension.ExtendWith;
-@RunWith(Parameterized.class)
+@ExtendWith(ParameterizedTestExtension.class)
public abstract class SparkDistributedDataScanTestBase
extends DataTableScanTestBase<BatchScan, ScanTask,
ScanTaskGroup<ScanTask>> {
@Parameters(name = "formatVersion = {0}, dataMode = {1}, deleteMode = {2}")
- public static Object[] parameters() {
- return new Object[][] {
- new Object[] {1, LOCAL, LOCAL},
- new Object[] {1, LOCAL, DISTRIBUTED},
- new Object[] {1, DISTRIBUTED, LOCAL},
- new Object[] {1, DISTRIBUTED, DISTRIBUTED},
- new Object[] {2, LOCAL, LOCAL},
- new Object[] {2, LOCAL, DISTRIBUTED},
- new Object[] {2, DISTRIBUTED, LOCAL},
- new Object[] {2, DISTRIBUTED, DISTRIBUTED}
- };
+ public static List<Object> parameters() {
Review Comment:
https://github.com/apache/iceberg/pull/9416#discussion_r1448313906
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/TestSparkDistributedDataScanDeletes.java:
##########
@@ -21,42 +21,39 @@
import static org.apache.iceberg.PlanningMode.DISTRIBUTED;
import static org.apache.iceberg.PlanningMode.LOCAL;
+import java.util.Arrays;
+import java.util.List;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.spark.SparkReadConf;
import org.apache.spark.sql.SparkSession;
import org.apache.spark.sql.internal.SQLConf;
-import org.junit.AfterClass;
-import org.junit.Before;
-import org.junit.BeforeClass;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.extension.ExtendWith;
-@RunWith(Parameterized.class)
+@ExtendWith(ParameterizedTestExtension.class)
public class TestSparkDistributedDataScanDeletes
extends DeleteFileIndexTestBase<BatchScan, ScanTask,
ScanTaskGroup<ScanTask>> {
- @Parameterized.Parameters(name = "dataMode = {0}, deleteMode = {1}")
- public static Object[] parameters() {
- return new Object[][] {
- new Object[] {LOCAL, LOCAL},
- new Object[] {LOCAL, DISTRIBUTED},
- new Object[] {DISTRIBUTED, LOCAL},
- new Object[] {DISTRIBUTED, DISTRIBUTED}
- };
+ @Parameters(name = "formatVersion = {0}, dataMode = {1}, deleteMode = {2}")
+ public static List<Object> parameters() {
Review Comment:
https://github.com/apache/iceberg/pull/9416#discussion_r1448313906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
