nastra commented on code in PR #9416:
URL: https://github.com/apache/iceberg/pull/9416#discussion_r1452233736
##########
core/src/test/java/org/apache/iceberg/ScanPlanningAndReportingTestBase.java:
##########
@@ -34,21 +35,24 @@
import org.apache.iceberg.metrics.ScanReport;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.assertj.core.api.InstanceOfAssertFactories;
-import org.junit.Test;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
+@ExtendWith(ParameterizedTestExtension.class)
public abstract class ScanPlanningAndReportingTestBase<
ScanT extends Scan<ScanT, T, G>, T extends ScanTask, G extends
ScanTaskGroup<T>>
- extends TableTestBase {
+ extends TestBase {
private final TestMetricsReporter reporter = new TestMetricsReporter();
- public ScanPlanningAndReportingTestBase() {
- super(2);
+ @Parameters(name = "formatVersion = {0}")
+ public static List<Object> parameters() {
+ return Arrays.asList(new Object[] {2});
Review Comment:
```suggestion
return Arrays.asList(2);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
