nastra commented on code in PR #9416:
URL: https://github.com/apache/iceberg/pull/9416#discussion_r1452151938
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -173,7 +173,7 @@ public class TestBase {
public TestTables.TestTable table = null;
@Parameters(name = "formatVersion = {0}")
- protected static List<Object[]> parameters() {
+ protected static List<Object> parameters() {
Review Comment:
in that case we should be able to change what's being returned here and in
the other places that have been modified in this PR to `return Arrays.asList(1,
2);` right? That way we don't need to have the additional wrapping of params
into `Object[]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
