chinmay-bhat commented on code in PR #9416:
URL: https://github.com/apache/iceberg/pull/9416#discussion_r1448313906
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -173,7 +173,7 @@ public class TestBase {
public TestTables.TestTable table = null;
@Parameters(name = "formatVersion = {0}")
- protected static List<Object[]> parameters() {
+ protected static List<Object> parameters() {
Review Comment:
Because for some tests, we only send 1 `Object` in the list, which is
satisfied by `List<Object>`.
For ex: from `DeleteFileIndexTestBase`
```
@Parameters(name = "formatVersion = {0}")
public static List<Object> parameters() {
return Arrays.asList(new Object[] {2});
}
```
Having List<Object[]> does not allow for the above case as it always expects
a List of Object arrays, where the Object arrays size cant be 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
