nk1506 commented on PR #8918: URL: https://github.com/apache/iceberg/pull/8918#issuecomment-1853370309
> We can have a **less disruptive change** by having a new constructor for `HiveMetastoreExtension` that doesn't take `DB_NAME` and skips DB creation if it is not set. > > Only use the new constructor for `TestHiveCatalog` and manually recreate DB in beforeEach() I was in the impression to make `HiveMetastoreExtension` specific to only metastore setup and teardown. All the clients of `HiveMetastoreExtension` should have responsibility to manage `databases` and `tables`. With overloaded constructor it will have hybrid flavour. Please share your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
