pvary commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1422793318
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException("Interrupted in call to rename", e);
+ } catch (RuntimeException e) {
Review Comment:
From my side:
- I am not sure #9143 is generally ok - maybe there were some reason behind
the `RuntimeException`, which I am not aware of.
- I prefer not to have to unwrap the `RuntimeException` in exception
handling - We need to understand why it is needed, and remove the root cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
