nk1506 commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1406295533
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException("Interrupted in call to rename", e);
+ } catch (RuntimeException e) {
Review Comment:
Yes,
[NoSuchObjectException](https://github.com/apache/iceberg/blob/f246614ed9d98f84eae13ff57768d377a95d3ced/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L251)
and
[TException](https://github.com/apache/iceberg/blob/f246614ed9d98f84eae13ff57768d377a95d3ced/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java#L258)
both are checked exceptions and being handled explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
