nk1506 commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1425058869
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -219,81 +208,6 @@ public void testInitializeCatalogWithProperties() {
.isEqualTo("/user/hive/testwarehouse");
}
- @Test
- public void testCreateTableTxnBuilder() throws Exception {
- Schema schema = getTestSchema();
- TableIdentifier tableIdent = TableIdentifier.of(DB_NAME, "tbl");
- String location = temp.resolve("tbl").toString();
-
- try {
- Transaction txn =
- catalog.buildTable(tableIdent,
schema).withLocation(location).createTransaction();
- txn.commitTransaction();
- Table table = catalog.loadTable(tableIdent);
-
- assertThat(table.location()).isEqualTo(location);
- assertThat(table.schema().columns()).hasSize(2);
- assertThat(table.spec().isUnpartitioned()).isTrue();
- } finally {
- catalog.dropTable(tableIdent);
- }
- }
-
- @ParameterizedTest
- @ValueSource(ints = {1, 2})
- public void testReplaceTxnBuilder(int formatVersion) {
Review Comment:
testReplaceTxnBuilder ->
[testReplaceTransaction](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L2042)
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -740,27 +563,6 @@ private void setNamespaceOwnershipAndVerify(
assertThat(database.getOwnerType()).isEqualTo(expectedOwnerTypePostSet);
}
- @Test
- public void testRemoveNamespaceProperties() throws TException {
Review Comment:
testRemoveNamespaceProperties ->
[testRemoveNamespaceProperties](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L314)
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -494,21 +356,6 @@ private void createNamespaceAndVerifyOwnership(
assertThat(db.getOwnerType()).isEqualTo(expectedOwnerType);
}
- @Test
- public void testListNamespace() throws TException {
Review Comment:
testListNamespace ->
[testListNamespaces](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L369)
.
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -219,81 +208,6 @@ public void testInitializeCatalogWithProperties() {
.isEqualTo("/user/hive/testwarehouse");
}
- @Test
- public void testCreateTableTxnBuilder() throws Exception {
Review Comment:
Few of the tests are being referred within the CatalogTests with different
name.
like
testCreateTableTxnBuilder ->
[testCreateTransaction](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L1486)
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -1210,35 +1012,4 @@ public void
testDatabaseLocationWithSlashInWarehouseDir() {
assertThat(database.getLocationUri()).isEqualTo("s3://bucket/database.db");
}
-
- @Test
- public void testRegisterTable() {
Review Comment:
testRegisterTable ->
[testRegisterTable](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L2623)
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -1210,35 +1012,4 @@ public void
testDatabaseLocationWithSlashInWarehouseDir() {
assertThat(database.getLocationUri()).isEqualTo("s3://bucket/database.db");
}
-
- @Test
- public void testRegisterTable() {
- TableIdentifier identifier = TableIdentifier.of(DB_NAME, "t1");
- catalog.createTable(identifier, getTestSchema());
- Table registeringTable = catalog.loadTable(identifier);
- catalog.dropTable(identifier, false);
- TableOperations ops = ((HasTableOperations) registeringTable).operations();
- String metadataLocation = ((HiveTableOperations)
ops).currentMetadataLocation();
- Table registeredTable = catalog.registerTable(identifier,
metadataLocation);
- assertThat(registeredTable).isNotNull();
- TestHelpers.assertSerializedAndLoadedMetadata(registeringTable,
registeredTable);
- String expectedMetadataLocation =
- ((HasTableOperations)
registeredTable).operations().current().metadataFileLocation();
- assertThat(metadataLocation).isEqualTo(expectedMetadataLocation);
- assertThat(catalog.loadTable(identifier)).isNotNull();
- assertThat(catalog.dropTable(identifier)).isTrue();
- }
-
- @Test
- public void testRegisterExistingTable() {
Review Comment:
testRegisterExistingTable ->
[testRegisterExistingTable](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L2688)
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -535,30 +382,6 @@ public void testNamespaceExists() throws TException {
.isFalse();
}
- @Test
- public void testSetNamespaceProperties() throws TException {
Review Comment:
testSetNamespaceProperties ->
[testSetNamespaceProperties](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L233)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
