nk1506 commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1425315871
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException("Interrupted in call to rename", e);
+ } catch (RuntimeException e) {
Review Comment:
@pvary @nastra is it a good idea for now to override the corresponding test
cases at `TestHiveCatalog`. and remove this specific `RuntimeException`
handling ?
Currently there is only one test cases which is failing
[testRenameTableDestinationTableAlreadyExists](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L779).
It is failing
[here](https://github.com/apache/iceberg/blob/7240752e18278b3454be141c2e4b121079004d8b/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L803).
With a backlog issue we can fix this `RuntimeException` issue.
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
