pvary commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1405931381
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -261,6 +261,12 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException("Interrupted in call to rename", e);
+ } catch (RuntimeException e) {
Review Comment:
I would wait a bit if some more knowledgable around #9143 would review that
PR.
> Yes, It seems AlterTable is wrapping exception into RuntimeException
[here](https://github.com/apache/iceberg/blob/bfe1d03c75b4a8bd2c15c925f39cdec28c312489/common/src/main/java/org/apache/iceberg/common/DynMethods.java#L70)
.
We do have tests for other exceptions except AlreadyExistsException. Also I
am not sure AlreadyExistsException exception is being thrown for renameTable.
Although NoSuchObjectException and TException is being thrown for retrieving
the table data.
If `NoSuchObjectException` and `TException` is thrown - do we handle it
correctly? Does it wrap into `RuntimeException`? Do we unwrap it before
checking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
