[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185470#comment-17185470
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
moleske commented on a change in pull request #5473:
URL: https://github.com/apache/geode/pull/5473#discussion_r477579763
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java
##########
@@ -33,6 +33,7 @@
*/
public class NullToken implements DataSerializableFixedID, Comparable {
+ @SuppressWarnings("lgtm[java/useless-null-check]")
Review comment:
Ok, the comments in the code help help. I do wonder if we should make
the link you posted available somewhere (like the readme or contributing.)
And as long as we put `@SuppressWarnings` at the lowest possible level that
should prevent the accident masking of other suppressions so that looks good.
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java
##########
@@ -33,6 +33,7 @@
*/
public class NullToken implements DataSerializableFixedID, Comparable {
+ @SuppressWarnings("lgtm[java/useless-null-check]")
Review comment:
Ok, the comments in the code help. I do wonder if we should make the
link you posted available somewhere (like the readme or contributing.)
And as long as we put `@SuppressWarnings` at the lowest possible level that
should prevent the accident masking of other suppressions so that looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
