[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184864#comment-17184864
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
DonalEvans commented on a change in pull request #5473:
URL: https://github.com/apache/geode/pull/5473#discussion_r476998382
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java
##########
@@ -33,6 +33,7 @@
*/
public class NullToken implements DataSerializableFixedID, Comparable {
+ @SuppressWarnings("lgtm[java/useless-null-check]")
Review comment:
Good call on explaining the suppression here and other places the
annotation is used. As for the different approaches to suppressing, [LGTM
requires that inline suppressions contain no line
breaks](https://lgtm.com/help/lgtm/alert-suppression#where-in-code-do-i-add-suppression-comments),
which would not be possible for some of the lines due to the spotless plugin
automatically wrapping comments that extend too far to the right. In those
cases, the @SuppressWarnings annotation is used, but is not used throughout
because it would potentially mask other, legitimate alerts in methods that are
currently present or that get introduced at a later date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
