[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186151#comment-17186151
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
DonalEvans commented on a change in pull request #5485:
URL: https://github.com/apache/geode/pull/5485#discussion_r478744835
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##########
@@ -1387,7 +1387,7 @@ void waitForViewInstallation(long id) throws
InterruptedException {
return;
}
synchronized (membershipViewIdGuard) {
- while (membershipViewIdAcknowledged < id &&
!stopper.isCancelInProgress()) {
+ while (!stopper.isCancelInProgress()) {
Review comment:
I think that this LGTM alert is incorrect, since it fails to take into
account the value of `membershipViewIdAcknowledged` being modified by another
thread, which seems to be what this method expects to happen. This false
positive alert has been suppressed in this PR:
https://github.com/apache/geode/pull/5473 to prevent it from showing up in
future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
