[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184744#comment-17184744
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
mhansonp commented on a change in pull request #5473:
URL: https://github.com/apache/geode/pull/5473#discussion_r476743929
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
##########
@@ -3583,7 +3597,7 @@ private void basicCreate(DiskRegion dr, DiskEntry entry,
ValueWrapper value, byt
logger.trace(LogMarker.PERSIST_WRITES_VERBOSE,
"basicCreate: id=<{}> key=<{}> valueOffset={} userBits={}
valueLen={} valueBytes={} drId={} versionTag={} oplog#{}",
abs(id.getKeyId()), entry.getKey(), startPosForSynchOp,
userBits,
- (value != null ? value.getLength() : 0),
value.getBytesAsString(), dr.getId(), tag,
Review comment:
Did you decrease protection here?
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
##########
@@ -5653,7 +5667,7 @@ private void deleteFile(final OplogFile olf) {
if (!olf.f.exists())
return;
assert olf.RAFClosed;
- if (!olf.RAFClosed || olf.raf != null) {
+ if (!olf.RAFClosed && olf.raf != null) {
Review comment:
Is the first part of the test required? "if (!olf.RAFClosed" It sits
below an assert that in order to pass must be true.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -2641,9 +2640,7 @@ private VersionedObjectList sendMsgByBucket(final Integer
bucketId, PutAllPRMess
retryTime.waitToRetryNode();
}
event.setPossibleDuplicate(true);
- if (prMsg != null) {
- prMsg.setPossibleDuplicate(true);
- }
+ prMsg.setPossibleDuplicate(true);
Review comment:
Is there a reason you reduced protection after adding it in elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
