[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184794#comment-17184794
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
DonalEvans commented on a change in pull request #5473:
URL: https://github.com/apache/geode/pull/5473#discussion_r476889738
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -2641,9 +2640,7 @@ private VersionedObjectList sendMsgByBucket(final Integer
bucketId, PutAllPRMess
retryTime.waitToRetryNode();
}
event.setPossibleDuplicate(true);
- if (prMsg != null) {
- prMsg.setPossibleDuplicate(true);
- }
+ prMsg.setPossibleDuplicate(true);
Review comment:
As with the other removed null check in Oplog.java, `prMsg` should never
be null in this method, so checking if it is null here simply causes LGTM to
assume that it may be null everywhere and complain any time a method is called
on it without first checking if it's null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
