[
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184787#comment-17184787
]
ASF GitHub Bot commented on GEODE-7864:
---------------------------------------
DonalEvans commented on a change in pull request #5473:
URL: https://github.com/apache/geode/pull/5473#discussion_r476877485
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java
##########
@@ -3583,7 +3597,7 @@ private void basicCreate(DiskRegion dr, DiskEntry entry,
ValueWrapper value, byt
logger.trace(LogMarker.PERSIST_WRITES_VERBOSE,
"basicCreate: id=<{}> key=<{}> valueOffset={} userBits={}
valueLen={} valueBytes={} drId={} versionTag={} oplog#{}",
abs(id.getKeyId()), entry.getKey(), startPosForSynchOp,
userBits,
- (value != null ? value.getLength() : 0),
value.getBytesAsString(), dr.getId(), tag,
Review comment:
In a sense, yes. The warning was being generated because checking if
`value` was null here implied that it could be null before/after this check,
and that calling methods on it could produce an NPE. However, when examining
the code path, `value` should never be null at this point, so the check was
redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code improvement refactoring
> ----------------------------
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
> Issue Type: Improvement
> Reporter: Nabarun Nag
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> This is a placeholder ticket.
> * this is used to do refactoring.
> * this ticket number is used to number the commit message.
> * this ticket will never be closed.
> * it will be used to mark improvements like correcting spelling mistakes,
> efficient java code, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
