andygrove opened a new pull request, #4067:
URL: https://github.com/apache/datafusion-comet/pull/4067

   ## Summary
   
   **Stacked on https://github.com/apache/datafusion-comet/pull/4057** — review 
and merge that PR first.
   
   - Removed the `getSupportLevel` override from `CometArrayAppend` since it 
always returned `Compatible()`, which is the default
   - Added `getIncompatibleReasons()` to all always-Incompatible expression 
serdes (CometArrayIntersect, CometArrayExcept, CometArrayJoin, 
CometArrayInsert, CometInitCap, CometStringSplit, CometGetJsonObject, 
CometFromUnixTime, CometJsonToStructs)
   - Added `getIncompatibleReasons()` and/or `getUnsupportedReasons()` to all 
conditional expression serdes that were missing them (~25 serdes across arrays, 
strings, datetime, math, structs, maps, misc)
   - Added compatibility guide pages for **string**, **map**, and **misc** 
expression categories
   - Registered new categories in `GenerateDocs` so content is auto-generated 
from the serde methods
   
   ## Test plan
   
   - [ ] Verify build succeeds (`mvn clean package -DskipTests`)
   - [ ] Verify generated docs include new expression compatibility notes
   - [ ] Spot-check that reasons text accurately describes the known 
incompatibilities/limitations
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to