andygrove commented on code in PR #4067:
URL: https://github.com/apache/datafusion-comet/pull/4067#discussion_r3140222331
##########
docs/source/user-guide/latest/expressions.md:
##########
@@ -226,94 +222,94 @@ Window support is disabled by default due to known
correctness issues. Tracking
Comet supports using the following aggregate functions within window contexts
with PARTITION BY and ORDER BY clauses.
-| Expression | Spark-Compatible? | Compatibility Notes |
-| ---------- | ----------------- | ------------------- |
-| Count | Yes | |
-| Max | Yes | |
-| Min | Yes | |
-| Sum | Yes | |
+| Expression |
+| ---------- |
+| Count |
+| Max |
+| Min |
+| Sum |
**Note:** Dedicated window functions such as `rank`, `dense_rank`,
`row_number`, `lag`, `lead`, `ntile`, `cume_dist`, `percent_rank`, and
`nth_value` are not currently supported and will fall back to Spark.
## Array Expressions
-| Expression | Spark-Compatible? | Compatibility Notes
|
-| -------------- | ----------------- |
----------------------------------------------------- |
-| ArrayAppend | Yes |
|
-| ArrayCompact | No |
|
-| ArrayContains | Yes |
|
-| ArrayDistinct | Yes |
|
-| ArrayExcept | No |
|
-| ArrayFilter | Yes | Only supports case where function is
`IsNotNull` |
-| ArrayInsert | Yes |
|
-| ArrayIntersect | No |
|
-| ArrayJoin | No |
|
-| ArrayMax | Yes |
|
-| ArrayMin | Yes |
|
-| ArrayRemove | Yes |
|
-| ArrayRepeat | No |
|
-| ArrayUnion | Yes |
|
-| ArraysOverlap | Yes |
|
-| CreateArray | Yes |
|
-| ElementAt | Yes | Input must be an array. Map inputs are
not supported. |
-| Flatten | Yes |
|
-| GetArrayItem | Yes |
|
+| Expression |
+| -------------- |
+| ArrayAppend |
+| ArrayCompact |
+| ArrayContains |
+| ArrayDistinct |
+| ArrayExcept |
+| ArrayFilter |
+| ArrayInsert |
+| ArrayIntersect |
+| ArrayJoin |
+| ArrayMax |
+| ArrayMin |
+| ArrayRemove |
+| ArrayRepeat |
+| ArrayUnion |
+| ArraysOverlap |
+| CreateArray |
+| ElementAt |
+| Flatten |
+| GetArrayItem |
## Map Expressions
-| Expression | Spark-Compatible? |
-| ------------- | ----------------- |
-| GetMapValue | Yes |
-| MapKeys | Yes |
-| MapEntries | Yes |
-| MapValues | Yes |
-| MapFromArrays | Yes |
+| Expression |
+| ------------- |
+| GetMapValue |
+| MapKeys |
+| MapEntries |
+| MapValues |
+| MapFromArrays |
## Struct Expressions
-| Expression | Spark-Compatible? | Compatibility Notes
|
-| -------------------- | ----------------- |
-----------------------------------------------------------------------------------------------------------------------
|
-| CreateNamedStruct | Yes |
|
-| GetArrayStructFields | Yes |
|
-| GetStructField | Yes |
|
-| JsonToStructs | No | Partial support. Requires
explicit schema.
|
-| StructsToJson | No | Does not support
Infinity/-Infinity for numeric types
([#3016](https://github.com/apache/datafusion-comet/issues/3016)) |
+| Expression |
+| -------------------- |
+| CreateNamedStruct |
+| GetArrayStructFields |
+| GetStructField |
+| JsonToStructs |
+| StructsToJson |
## Conversion Expressions
-| Expression | Spark-Compatible | Compatibility Notes
|
-| ---------- | ------------------------ |
-------------------------------------------------------------------------------------------
|
-| Cast | Depends on specific cast | See the [Comet Compatibility Guide]
for list of supported cast expressions and known issues |
+| Expression |
+| ---------- |
+| Cast |
## SortOrder
-| Expression | Spark-Compatible? | Compatibility Notes |
-| ---------- | ----------------- | ------------------- |
-| NullsFirst | Yes | |
-| NullsLast | Yes | |
-| Ascending | Yes | |
-| Descending | Yes | |
+| Expression |
+| ---------- |
+| NullsFirst |
+| NullsLast |
+| Ascending |
+| Descending |
## Other
-| Expression | Spark-Compatible? | Compatibility Notes
|
-| ---------------------------- | ----------------- |
--------------------------------------------------------------------------- |
-| Alias | Yes |
|
-| AttributeReference | Yes |
|
-| BloomFilterMightContain | Yes |
|
-| Coalesce | Yes |
|
-| CheckOverflow | Yes |
|
-| KnownFloatingPointNormalized | Yes |
|
-| Literal | Yes |
|
-| MakeDecimal | Yes |
|
-| MonotonicallyIncreasingID | Yes |
|
-| NormalizeNaNAndZero | Yes |
|
-| PromotePrecision | Yes |
|
-| RegExpReplace | No | Uses Rust regexp engine,
which has different behavior to Java regexp engine |
-| ScalarSubquery | Yes |
|
-| SparkPartitionID | Yes |
|
-| ToPrettyString | Yes |
|
-| UnscaledValue | Yes |
|
+| Expression |
+| ---------------------------- |
+| Alias |
Review Comment:
maybe this doc does not need tables now and can just be simple lists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
