parthchandra commented on code in PR #4067:
URL: https://github.com/apache/datafusion-comet/pull/4067#discussion_r3140308388
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -205,6 +205,8 @@ object CometAverage extends
CometAggregateExpressionSerde[Average] {
object CometSum extends CometAggregateExpressionSerde[Sum] {
+ override def getIncompatibleReasons(): Seq[String] = Seq("Falls back to
Spark in ANSI mode.")
Review Comment:
I believe ansi mode is implemented for sum.
https://github.com/apache/datafusion-comet/issues/531
##########
spark/src/main/scala/org/apache/comet/serde/strings.scala:
##########
@@ -33,6 +33,10 @@ import
org.apache.comet.serde.QueryPlanSerde.{createBinaryExpr, exprToProtoInter
object CometStringRepeat extends CometExpressionSerde[StringRepeat] {
+ override def getCompatibleNotes(): Seq[String] = Seq(
Review Comment:
Is this an incompatibility where we should be falling back?
##########
spark/src/main/scala/org/apache/comet/serde/unixtime.scala:
##########
@@ -29,6 +29,11 @@ import
org.apache.comet.serde.QueryPlanSerde.{exprToProtoInternal, optExprWithIn
// https://github.com/apache/datafusion/issues/16594
object CometFromUnixTime extends CometExpressionSerde[FromUnixTime] {
+ override def getIncompatibleReasons(): Seq[String] = Seq(
+ "Only supports the default datetime format pattern `yyyy-MM-dd HH:mm:ss`."
+
Review Comment:
`Unsupported` instead of `Incompatible` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
