andygrove commented on code in PR #4067:
URL: https://github.com/apache/datafusion-comet/pull/4067#discussion_r3140359823
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -205,6 +205,8 @@ object CometAverage extends
CometAggregateExpressionSerde[Average] {
object CometSum extends CometAggregateExpressionSerde[Sum] {
+ override def getIncompatibleReasons(): Seq[String] = Seq("Falls back to
Spark in ANSI mode.")
Review Comment:
This was moved over from the supported expression doc, but I agree, this is
incorrect. Let me file an issue for all of the discrepancies found in this PR
so we don't have to trigger another CI cycle on this one (hopefully).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
