andygrove commented on code in PR #4067:
URL: https://github.com/apache/datafusion-comet/pull/4067#discussion_r3140218918
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -245,6 +247,10 @@ object CometSum extends CometAggregateExpressionSerde[Sum]
{
}
object CometFirst extends CometAggregateExpressionSerde[First] {
+
+ override def getCompatibleNotes(): Seq[String] = Seq(
Review Comment:
- `getCompatibleNotes` is for compatibility issues that we decided to accept
and still accelerate the expression
- `getIncompatibleReasons` is for compatibility issues that we decided to
fall back for and have user opt-in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
