Alon Bar-Lev has posted comments on this change. Change subject: core: i18n welcome page with branding ......................................................................
Patch Set 4: (1 inline comment) .................................................... File packaging/branding/ovirt.brand/messages.properties Line 46: obrand.welcome.section1.row1.url=UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?locale={0} Line 47: obrand.welcome.section1.row2.text=Administrator Portal Line 48: obrand.welcome.section1.row2.url=webadmin/webadmin/WebAdmin.html?locale={0} Line 49: obrand.welcome.section1.row3.text=Reports Portal Line 50: obrand.welcome.section1.row3.url=OvirtEngineWeb/RedirectServlet?Page=Reports I think that you can never anticipate what customization in needed is such page. Anyway, if you take that approach, please give names for the above section1 and raws, as you do know where these are going. -- To view, visit http://gerrit.ovirt.org/16359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches