Alexander Wels has posted comments on this change. Change subject: core: i18n welcome page with branding ......................................................................
Patch Set 5: If you notice the keys match up to the keys in the messages file. I basically just use a regex capture group to find the key, then use the key to look up the text in the resource bundle. If you have a better suggestion I am all ears. One other thing I just thought about, this setup requires each branding to have their own welcome page template. Should we support some kind of inheritance. If so, what should that inheritance be? For instance if the oVirt template defines the links to the portals. And we have ACME define some links to documentation or whatever, should ACME also define the links to the portal? -- To view, visit http://gerrit.ovirt.org/16359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
