Alon Bar-Lev has posted comments on this change. Change subject: core: i18n welcome page with branding ......................................................................
Patch Set 5: > If you notice the keys match up to the keys in the messages file. I basically > just use a regex capture group to find the key, then use the key to look up > the text in the resource bundle. Well, I thought as minimum to replace the '.' with '_' in both files... :) > Should we support some kind of inheritance. Well, this is getting very complex, no? the simplest method would be to aggregate all into single html... or... do what I suggested at first... add ability to inject javascript, so that this javascript can modify exiting document... adding whatever needed in all places. -- To view, visit http://gerrit.ovirt.org/16359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
