Alexander Wels has posted comments on this change. Change subject: core: i18n welcome page with branding ......................................................................
Patch Set 5: > Well, this is getting very complex, no? the simplest method would be to > aggregate all into single html... Yes, I already have the ability to obtain the template for each theme, it is trivial to just aggregate them and use the aggregate as the template. I am just trying to decide if that is something we want to do or not. It will take away some flexibility from the branding author, on the other hand it will make creating a branding theme easier as you don't NEED a template as it can just fall back on template of a previous theme. -- To view, visit http://gerrit.ovirt.org/16359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
