Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Disable gluster cli based snapshot scheduling ......................................................................
Patch Set 8: (3 comments) https://gerrit.ovirt.org/#/c/39945/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 563: Line 564: // If meta volume then set the CLI based snapshot scheduling flag accordingly Line 565: if (GlusterFeatureSupported.glusterSnapshot(cluster.getCompatibilityVersion()) Line 566: && cluster.getIsGlusterCliBasedSchedulingOn() Line 567: && (Config.<String> getValue(ConfigValues.GlusterMetaVolumeName)).equalsIgnoreCase(volume.getName())) { > Shouldn't we disable only if engine has scheduled snapshots on volume? There was a input from Rajesh saying that during sync of volumes, set the flag in gluster to oVirt Line 568: Line 569: VdcReturnValueBase returnValue = Line 570: Backend.getInstance() Line 571: .runInternalAction(VdcActionType.DisableGlusterCliSnapshotScheduleInternal, Line 578: > this is not required, as the internal command would update it, right? Correct. would remove this. https://gerrit.ovirt.org/#/c/39945/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 259: > get prefix not required Done -- To view, visit https://gerrit.ovirt.org/39945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc06f246f30769c5edaf981876c2a51ddd4fffd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
